-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove deprecated options #267
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/d4nnn4yya |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
EDIT: Ignore me, I was doing the wrong thing. |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
As part of this make sure you read https://blog.golang.org/v2-go-modules many people at my work have tried to bump to v2 but not read that and broken things in odd ways. |
yep, here's a picture of me reading it the last time I needed: 😂 |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
In the past, I simply changed the module to Maybe just keep a v2 branch? Anyone with more experience with that? |
IMHO ¯_(ツ)_/¯ and we can just append |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 70.38% 69.44% -0.94%
==========================================
Files 9 9
Lines 1138 1103 -35
==========================================
- Hits 801 766 -35
Misses 209 209
Partials 128 128
Continue to review full report at Codecov.
|
Ya that works, I don't really like the branch or sub folder method either, but it does make supporting older versions easier if we need to for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
regarding #255, removing the old options.
We will then version this as v2 (breaking change). Easier than keep a lot of things working.
Will still have to do the deprecation notice et all on goreleaser, but its on a single place then.