feat: remove deprecated options

[caarlos0]

regarding #255, removing the old options.

We will then version this as v2 (breaking change). Easier than keep a lot of things working.

Will still have to do the deprecation notice et all on goreleaser, but its on a single place then.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/d4nnn4yya
✅ Preview: https://nfpm-git-v2.goreleaser.vercel.app

[caarlos0]

@djgilcrease I'm not sure why, but symlink tests on rpm and deb are failing 🤔

I think it wasn't supposed to work before actually, since the actual file is never added to the package... does that makes sense?

EDIT: Ignore me, I was doing the wrong thing.

[djgilcrease]

As part of this make sure you read https://blog.golang.org/v2-go-modules many people at my work have tried to bump to v2 but not read that and broken things in odd ways.

[caarlos0]

As part of this make sure you read https://blog.golang.org/v2-go-modules many people at my work have tried to bump to v2 but not read that and broken things in odd ways.

yep, here's a picture of me reading it the last time I needed:

😂

[caarlos0]

As part of this make sure you read https://blog.golang.org/v2-go-modules many people at my work have tried to bump to v2 but not read that and broken things in odd ways.

In the past, I simply changed the module to /v2 in go.mod (e.g. https://github.com/caarlos0/env), but yeah, they recommend a v2 subfolder, which I absolutely hate and 0/10 will not do it. Just renaming works for go mod and non-go mod usage, but old versions won't work under go mods anymore (if I recall correctly).

Maybe just keep a v2 branch? Anyone with more experience with that?

[caarlos0]

Other strategies may keep major versions on separate branches. However, if v2+ source code is on the repository's default branch (usually master), tools that are not version-aware — including the go command in GOPATH mode — may not distinguish between major versions.

IMHO ¯_(ツ)_/¯ and we can just append /v2 to the go.mod file... YOLO

[codecov]

Codecov Report

Merging #267 (8d06195) into master (df152db) will decrease coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   70.38%   69.44%   -0.94%     
==========================================
  Files           9        9              
  Lines        1138     1103      -35     
==========================================
- Hits          801      766      -35     
  Misses        209      209              
  Partials      128      128              

Impacted Files	Coverage Δ
cmd/nfpm/main.go	0.00% <ø> (ø)
nfpm.go	79.59% <100.00%> (-5.38%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df152db...8d06195. Read the comment docs.

[djgilcrease]

Other strategies may keep major versions on separate branches. However, if v2+ source code is on the repository's default branch (usually master), tools that are not version-aware — including the go command in GOPATH mode — may not distinguish between major versions.

IMHO ¯_(ツ)_/¯ and we can just append /v2 to the go.mod file... YOLO

Ya that works, I don't really like the branch or sub folder method either, but it does make supporting older versions easier if we need to for some reason.

[djgilcrease]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.