Kadai3-1 uobikiemukot #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizkei
reviewed
Nov 30, 2018
|
|
||
| // ReadInput read io.Reader and return string channel | ||
| func ReadInput(ctx context.Context, in io.Reader) <-chan string { | ||
| ch := make(chan string, 0) |
There was a problem hiding this comment.
fixed: 33fc2e4
kadai3-1/uobikiemukot/main.go
Outdated
|
|
||
| func main() { | ||
| bg := context.Background() | ||
| ctx, cancel := context.WithCancel(bg) |
There was a problem hiding this comment.
defer cancel は呼び忘れないようにしましょう
https://golang.org/pkg/context/
Failing to call the CancelFunc leaks the child and its children until the parent is canceled or the timer fires.
There was a problem hiding this comment.
fixed: 01f9a44
| go func() { | ||
| defer close(ch) | ||
| sc := bufio.NewScanner(in) | ||
| for sc.Scan() { |
There was a problem hiding this comment.
bufio.NewScanner で os.Stdin を渡しているため、 sc.Scan は標準入力でenterが入力するまでブロックします
そして、下記の箇所でinputのみを待ってしまうために、なにもせず5秒経過したとしても0問正解として終わらず、その後に入力されたひとつ目の入力を受け付けてしまいます
https://github.com/gopherdojo/dojo4/pull/47/files#diff-4d4d5b583e35d4c540d67179051f4406R29
There was a problem hiding this comment.
fixed: ff5211e
|
レビューありがとうございました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題3-1
時間が足りず、最低限のものしかできていません 😿