-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #757: use stretchr/testify/require #758
Conversation
8438859
to
1a50af9
Compare
You've put this in the v0.6.2 milestone, but it looks like there are changes to the other PRs that are targeting v0.6.1 that also have testify updates. Do we need to have all of them target one milestone? |
I changed the We don't need to have them all in one milestone and do them one step at a time as long as they're all converted at some point. |
06608c5
to
645ad93
Compare
4270340
to
34d14f1
Compare
All of them have to pass for the parent test to pass as well.
stretchr/testify is more strict in equality testing and provides more useful debugging output.
In a first step I've replaced all usages of
verify.Values
withtestify
and found two glitches in the variant tests.In later steps I'll go through the
if got, want
pattern and gradually replace them withrequire
as well.