Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake + PortAudio #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CMake + PortAudio #70

wants to merge 5 commits into from

Conversation

jwinarske
Copy link

@jwinarske jwinarske commented Feb 25, 2020 •
edited
Loading

I implemented this last year. Open to changes.

Build Example on Linux:

mkdir build && cd build
cmake .. -DCMAKE_INSTALL_PREFIX=../bin
make -j

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jwinarske jwinarske requested a review from Fleker February 25, 2020 05:29
@jwinarske
All demos running on Linux, Mac, Windows, and Android builds. Tested …
3ff35d1 
…using Appveyor, and Travis-CI.

Removed audio_*_alsa.* files in favor of the PortAudio implementation.
audio_input_file.cc - Windows requires streams opened with binary flag.
base64_encode.cc - u_char is not defined on some systems (Mac), using uint8_t instead.

There is a pending PR for my CMake implementation to "build" googleapis tree.  Once this is accepted, cmake/build_googleapis.cmake will be removed.

When Cross compiling, a host implementation of grpc is required.
@jwinarske
grpc bin default path when cross compiling
e0251a3
@jwinarske
Move gRPC to v1.27.2
3b42142
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Fleker
Copy link
Collaborator

Fleker commented Mar 3, 2020

Thanks for the PR, although this seems like too significant of a refactor to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fleker Fleker Awaiting requested review from Fleker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwinarske @googlebot @Fleker