Upgrade the compileSdkVersion and buildToolsVersion. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musingsun
commented
Jan 1, 2024
musingsun
commented
- The current compileSdkVersion is 34 and buildToolsVersion is "34.0.0".
- Due to non-compliance of IMA SDK with Android 14, we need to temporarily disable ads insertion on Android 14. https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading
- Replace the dependencies of Android's Support Library with the Android Jetpack Library.
- Upgrade AGP version to 8.2.0.
- Remove the androidTest cases that should be re-implemented in the library module.
- The current compileSdkVersion is 34 and buildToolsVersion is "34.0.0". - Due to non-compliance of IMA SDK with Android 14, we need to temporarily disable ads insertion on Android 14. https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading - Replace the dependencies of Android's Support Library with the Android Jetpack Library. - Upgrade AGP version to 8.2.0. - Remove the androidTest cases that should be re-implemented in the library module.
rezaultf
reviewed
Sep 9, 2024
| implementation "com.android.support:appcompat-v7:$appCompatVersion" | ||
| implementation "androidx.recyclerview:recyclerview:1.3.0" | ||
| implementation "androidx.leanback:leanback:1.0.0" | ||
| implementation "androidx.appcompat:appcompat:1.6.1" | ||
| implementation 'com.google.android.exoplayer:exoplayer:r1.5.14' |
There was a problem hiding this comment.
Hi, r1.5.14 is not available now. How can you got this dependency? Do you have .jar file of this version? Otherwise this PR will not work anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.