Added functions to create custom desktops with CreateDesktop and CreateDesktopEx #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranid
requested changes
Nov 29, 2021
| @@ -1336,6 +1336,27 @@ SafeKernelObjectHandle hTemplateFile | |||
| SECURITY_ATTRIBUTES lpsa | |||
| ); | |||
|
|
|||
| [DllImport("user32.dll", EntryPoint = "CreateDesktop", CharSet = CharSet.Unicode, SetLastError = true)] | |||
There was a problem hiding this comment.
Don't need to specify the EntryPoint property.
| SECURITY_ATTRIBUTES attributes); | ||
|
|
||
| [DllImport("user32.dll", CharSet = CharSet.Unicode, SetLastError = true)] | ||
| internal static extern SafeKernelObjectHandle CreateDesktopEx( |
There was a problem hiding this comment.
You should just define the Ex version which is supported on Vista+, no need to specify both versions of the function.
| IntPtr device, // must be null. | ||
| IntPtr deviceMode, // must be null, | ||
| int flags, // use 0 | ||
| AccessMask dwDesiredAccess, |
There was a problem hiding this comment.
I'd use DesktopAccessRights for this type rather than AccessMask.
| int flags, // use 0 | ||
| AccessMask dwDesiredAccess, | ||
| SECURITY_ATTRIBUTES attributes, | ||
| ulong heapSize, |
There was a problem hiding this comment.
According to the definition of the function the heapSize is ULONG, which is 32-bit in the native APIs. ulong in C# is 64bit. Use int or uint instead.
| /// <returns>The Desktop.</returns> | ||
| public static NtDesktop CreateDesktop(string name) | ||
| { | ||
| var handle = Win32NativeMethods.CreateDesktop(name, IntPtr.Zero, IntPtr.Zero, 0, WindowStationAccessRights.MaximumAllowed, null); |
There was a problem hiding this comment.
Call the CreateDesktop(string name, ulong heapsize) to use the Ex version of the function with the heapsize set to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Win32Utils has a CreateWindowStation function, but did not have any helper methods to create custom desktops via CreateDesktop and CreateDesktopEx.