Feature/await expression #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saelo
reviewed
Nov 18, 2024
| @@ -1040,6 +1040,14 @@ public class JavaScriptCompiler { | |||
| case .v8IntrinsicIdentifier: | |||
| fatalError("V8IntrinsicIdentifiers must be handled as part of their surrounding CallExpression") | |||
|
|
|||
| case .awaitExpression(let awaitExpression): | |||
| // TODO await is also allowed at the top level of a module | |||
There was a problem hiding this comment.
Ah yeah that's a good point. That's probably a bigger project and we need to support module fuzzing for that, so leaving this TODO and throwing an error sounds good.
|
Thanks! |
parthdt
pushed a commit
to parthdt/fuzzilli
that referenced
this pull request
Dec 14, 2024
* Implements compilation of the await expression * Implements basic test to ensure that await is covered in CompilerTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.