Add njs as a target/profile #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saelo
reviewed
Jul 10, 2024
| @@ -0,0 +1,59 @@ | |||
| // Copyright 2020 Google LLC | |||
There was a problem hiding this comment.
Nit: please update to 2024 :)
There was a problem hiding this comment.
whoops, fixed :^)
Targets/njs/README.md
Outdated
|
|
||
| To build njs for fuzzing: | ||
| * Step 1 - prepare env | ||
| * Run `fuzzbuild.sh`, this will: |
There was a problem hiding this comment.
So typically, fuzzbuild.sh just takes care of performing the build, not downloading the source code. You could rename this to maybe setup.sh or so, and then put steps 2 and 3 into a fuzzbuild.sh. That would be more consistent. No strong opinion though, this is also fine.
There was a problem hiding this comment.
That's actually a good point, changed it. Thanks
* `NjsProfile.swift`: fix typo * Split the helper scripts into `setup.sh` and `fuzzbuild.sh` * Update the README.md file accordingly
0xbigshaq
force-pushed
the
add-njs-target
branch
from
2d5967d to
26f97cf
Compare
|
Thanks again! |
saelo
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Samuel/Carl,
I took a small side-quest few weeks ago(for fun) and used fuzzilli. It led to writing this thingy.
This is my attempt to give back :D thank you for creating this project.
This PR adds njs as a new target/profile to fuzz so everyone can enjoy hehe