Skip to content

Commit

Permalink
Update V8 Profiles with new crash test.
Browse files Browse the repository at this point in the history
New crash tests make sure that our builds have DEBUG defined.
  • Loading branch information
carl-smith committed May 23, 2024
1 parent 390a1c5 commit e366dcc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Sources/FuzzilliCli/Profiles/V8HoleFuzzingProfile.swift
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ let v8HoleFuzzingProfile = Profile(
("fuzzilli('FUZZILLI_CRASH', 0)", .shouldCrash),
("fuzzilli('FUZZILLI_CRASH', 7)", .shouldCrash),

// Check that DEBUG is not defined.
("fuzzilli('FUZZILLI_CRASH', 8)", .shouldNotCrash),

// DCHECK and CHECK failures should be ignored.
("fuzzilli('FUZZILLI_CRASH', 1)", .shouldNotCrash),
("fuzzilli('FUZZILLI_CRASH', 2)", .shouldNotCrash),
Expand Down
2 changes: 2 additions & 0 deletions Sources/FuzzilliCli/Profiles/V8Profile.swift
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,8 @@ let v8Profile = Profile(
("fuzzilli('FUZZILLI_CRASH', 2)", .shouldCrash),
// Wild-write
("fuzzilli('FUZZILLI_CRASH', 3)", .shouldCrash),
// Check that DEBUG is defined.
("fuzzilli('FUZZILLI_CRASH', 8)", .shouldCrash),

// TODO we could try to check that OOM crashes are ignored here ( with.shouldNotCrash).
],
Expand Down

0 comments on commit e366dcc

Please sign in to comment.