Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang compilation issue #85

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

krzyw1x
Copy link
Contributor

@krzyw1x krzyw1x commented Nov 26, 2024

Fix for build issues with homebrew clang-19:

/opt/homebrew/Cellar/llvm/19.1.4/bin/../include/c++/v1/__memory/allocator.h:95:17: error: static assertion failed due to requirement '!is_const<const std::string>::value': std::allocator does not support const types
   95 |   static_assert(!is_const<_Tp>::value, "std::allocator does not support const types");
      |                 ^~~~~~~~~~~~~~~~~~~~~

You can find description of the problem here: https://stackoverflow.com/questions/21365331/which-is-correct-vectorconst-string-or-const-vectorstring

Fix for build issues with homebrew clang-19
```
/opt/homebrew/Cellar/llvm/19.1.4/bin/../include/c++/v1/__memory/allocator.h:95:17: error: static assertion failed due to requirement '!is_const<const std::string>::value': std::allocator does not support const types
   95 |   static_assert(!is_const<_Tp>::value, "std::allocator does not support const types");
      |                 ^~~~~~~~~~~~~~~~~~~~~
```

You can find description of the problem here: https://stackoverflow.com/questions/21365331/which-is-correct-vectorconst-string-or-const-vectorstring
@ifratric
Copy link
Collaborator

Thanks!

@ifratric ifratric merged commit ed07784 into googleprojectzero:master Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants