-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crypto replaced by crypto-js #676
fix: crypto replaced by crypto-js #676
Conversation
I hope you will approve this one because that rn-nodeify workaround/hack (that I tried earlier) is really ugly and uninspiring. This fix should allow other people to use this package with web/mobile applications with no major changes to their codebases. |
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 22 22
Lines 783 783
Branches 127 127
=======================================
Hits 780 780
Misses 3 3
Continue to review full report at Codecov.
|
Thank you! |
### [3.2.4](v3.2.3...v3.2.4) (2021-10-07) ### Bug Fixes * crypto replaced by crypto-js ([#676](#676)) ([f116aa0](f116aa0)) ### Build System * **deps-dev:** bump @types/node from 16.9.6 to 16.10.2 ([#672](#672)) ([e471199](e471199)) * **deps-dev:** bump jest from 27.2.2 to 27.2.4 ([#673](#673)) ([5a8470c](5a8470c)) * **deps-dev:** bump typedoc from 0.22.4 to 0.22.5 ([#671](#671)) ([634d4eb](634d4eb))
### [3.2.4](googlemaps/google-maps-services-js@v3.2.3...v3.2.4) (2021-10-07) ### Bug Fixes * crypto replaced by crypto-js ([#676](googlemaps/google-maps-services-js#676)) ([cfa6ed1](googlemaps/google-maps-services-js@cfa6ed1)) ### Build System * **deps-dev:** bump @types/node from 16.9.6 to 16.10.2 ([#672](googlemaps/google-maps-services-js#672)) ([ba6c336](googlemaps/google-maps-services-js@ba6c336)) * **deps-dev:** bump jest from 27.2.2 to 27.2.4 ([#673](googlemaps/google-maps-services-js#673)) ([571159e](googlemaps/google-maps-services-js@571159e)) * **deps-dev:** bump typedoc from 0.22.4 to 0.22.5 ([#671](googlemaps/google-maps-services-js#671)) ([8d3e63f](googlemaps/google-maps-services-js@8d3e63f))
### [3.2.4](googlemaps/google-maps-services-js@v3.2.3...v3.2.4) (2021-10-07) ### Bug Fixes * crypto replaced by crypto-js ([#676](googlemaps/google-maps-services-js#676)) ([f116aa0](googlemaps/google-maps-services-js@f116aa0)) ### Build System * **deps-dev:** bump @types/node from 16.9.6 to 16.10.2 ([#672](googlemaps/google-maps-services-js#672)) ([e471199](googlemaps/google-maps-services-js@e471199)) * **deps-dev:** bump jest from 27.2.2 to 27.2.4 ([#673](googlemaps/google-maps-services-js#673)) ([5a8470c](googlemaps/google-maps-services-js@5a8470c)) * **deps-dev:** bump typedoc from 0.22.4 to 0.22.5 ([#671](googlemaps/google-maps-services-js#671)) ([634d4eb](googlemaps/google-maps-services-js@634d4eb))
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #647 🦕