Skip to content

Commit

Permalink
[fontc] Set --no-production-names
Browse files Browse the repository at this point in the history
  • Loading branch information
cmyr committed Oct 31, 2024
1 parent f14c7bc commit 4d011a3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Lib/gftools/builder/fontc.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ def modify_config(self, config: dict):
config["buildWebfont"] = False
config["buildSmallCap"] = False
config["splitItalic"] = False
# set --no-production-names, because it's easier to debug
extra_args = config.get("extraFontmakeArgs") or ""
extra_args += " --no-production-names"
config["extraFontmakeArgs"] = extra_args
# override config to turn not build instances if we're variable
if self.will_build_variable_font(config):
config["buildStatic"] = False
Expand Down
2 changes: 2 additions & 0 deletions Lib/gftools/builder/operations/fontc/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ def rewrite_one_arg(args: List[str]) -> str:
else:
# glue the filter back together for better reporting below
next_ = f"{next_} {filter_}"
elif next_ == "--no-production-names":
return next_
else:
raise ValueError(f"unknown fontmake arg '{next_}'")
return ""

0 comments on commit 4d011a3

Please sign in to comment.