Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Commit

Permalink
Merge pull request #7 from davidmorgan/update-lints
Browse files Browse the repository at this point in the history
Update lints.
  • Loading branch information
davidmorgan authored Sep 27, 2018
2 parents 9a94e8f + 86326fb commit 5e84256
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
## 1.2.0

- Enforce `unawaited_futures`. Stop enforcing `control_flow_in_finally` and
`throw_in_finally`.

## 1.1.0

- Moved `analysis_options.yaml` under `lib` so you can import it directly from
- Move `analysis_options.yaml` under `lib` so you can import it directly from
your own `analysis_options.yaml`. See `README.md` for example.

## 1.0.0
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ and others. See note about Flutter SDK style below.
`avoid_as`
does not reflect standard usage. See note about Flutter SDK style below.

`control_flow_in_finally`
does not offer enough value: people are unlikely to do this by accident,
and there are occasional valid uses.

`empty_statements`
is superfluous, enforcing use of `dartfmt` is sufficient to make empty
statements obvious.
Expand All @@ -80,6 +84,10 @@ is superfluous, enforcing use of `dartfmt` is sufficient to make empty
`prefer_final_locals`
does not reflect standard usage.

`throw_in_finally`
does not offer enough value: people are unlikely to do this by accident,
and there are occasional valid uses.

Note on Flutter SDK Style: some lints were created specifically to support
Flutter SDK development. Flutter app developers should instead use standard
Dart style as described in Effective Dart, and should not use these lints.
Expand Down
3 changes: 1 addition & 2 deletions lib/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,12 @@ linter:
- avoid_relative_lib_imports
- avoid_return_types_on_setters
- avoid_types_as_parameter_names
- control_flow_in_finally
- no_duplicate_case_values
- prefer_contains
- prefer_equal_for_default_values
- prefer_is_not_empty
- recursive_getters
- throw_in_finally
- unrelated_type_equality_checks
- use_rethrow_when_possible
- unawaited_futures
- valid_regexps

0 comments on commit 5e84256

Please sign in to comment.