-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename rst files to avoid conflict with service names #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizcology
requested review from
a team,
SurferJeffAtGoogle,
chingor13 and
bcoe
as code owners
September 8, 2023 17:44
dizcology
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 8, 2023
Please re-assign to me when ready for review. |
suztomo
added a commit
that referenced
this pull request
Sep 13, 2023
Just to see the validity of the test failures in #1856
Kokoro CI failed: https://source.cloud.google.com/results/invocations/a1603b4f-1b4d-4a21-9cfc-afdff613edd9/targets/cloud-devrel%2Fclient-libraries%2Fsynthtool%2Fpresubmit/log
|
The specific test that is failing is part of the node templates. |
dizcology
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 16, 2023
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 16, 2023
dizcology
added
owlbot:run
Add this label to trigger the Owlbot post processor.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Oct 16, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 17, 2023
parthea
approved these changes
Oct 17, 2023
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 26, 2023
This PR updates the post processor image to the latest one which is `gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:590e38040466dced83fa3f0817b8b79723ca3a55ce8c61243d911fe253662f04`. The latest image includes the following fixes: googleapis/synthtool#1856 googleapis/synthtool#1881 Run the following commands to obtain the latest sha256 ``` docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest ``` ``` partheniou@partheniou-vm-3:~$ docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest [gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:590e38040466dced83fa3f0817b8b79723ca3a55ce8c61243d911fe253662f04] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python GAPIC generator will rename the template rst files, adding trailing underscore to avoid name collision when an API has a service called
Services
googleapis/gapic-generator-python#1706:services.rst -> services_.rst
types.rst -> types_.rst
This PR makes the corresponding change in
index.rst
files.