fix: handle entries that cannot be disambiguated (#59)

docfx_yaml/extension.py

@@ -796,6 +796,9 @@ def find_unique_name(package_name, entries):
         if name != "google" and name != "cloud" and entries[name] == 1:
             return [name, package_name[-1]]
 
+    # If there is no way to disambiguate, return the identifier name
+    return [package_name[-1]]
+
 # Used to disambiguate names that have same entries.
 def disambiguate_toc_name(toc_yaml):
     name_entries = {}

tests/test_unit.py

@@ -49,6 +49,21 @@ def test_disambiguate_toc_name(self):
         self.assertEqual(yaml_want, yaml_got)
 
 
+    def test_disambiguate_toc_name_duplicate(self):
+
+        want_file = open('tests/yaml_post_duplicate.yaml', 'r')
+        yaml_want = load(want_file, Loader=Loader)
+
+        test_file = open('tests/yaml_pre_duplicate.yaml', 'r')
+        yaml_got = load(test_file, Loader=Loader)
+        disambiguate_toc_name(yaml_got)
+
+        want_file.close()
+        test_file.close()
+
+        self.assertEqual(yaml_want, yaml_got)
+
+
     def test_reference_in_summary(self):
         lines_got = """
 If a ``stream`` is attached to this download, then the downloaded

tests/yaml_post_duplicate.yaml

@@ -0,0 +1,34 @@
+[
+   {
+      "name":"client_info",
+      "uidname":"google.api_core.client_info",
+      "items":[
+         {
+            "name":"Overview",
+            "uidname":"google.api_core.client_info",
+            "uid":"google.api_core.client_info"
+         },
+         {
+            "name":"ClientInfo",
+            "uidname":"google.api_core.client_info.ClientInfo",
+            "uid":"google.api_core.client_info.ClientInfo"
+         }
+      ]
+   },
+   {
+      "name":"gapic_v1.client_info",
+      "uidname":"google.api_core.gapic_v1.client_info",
+      "items":[
+         {
+            "name":"Overview",
+            "uidname":"google.api_core.gapic_v1.client_info",
+            "uid":"google.api_core.gapic_v1.client_info"
+         },
+         {
+            "name":"ClientInfo",
+            "uidname":"google.api_core.gapic_v1.client_info.ClientInfo",
+            "uid":"google.api_core.gapic_v1.client_info.ClientInfo"
+         }
+      ]
+   },
+]

tests/yaml_pre_duplicate.yaml

@@ -0,0 +1,34 @@
+[
+   {
+      "name":"client_info",
+      "uidname":"google.api_core.client_info",
+      "items":[
+         {
+            "name":"Overview",
+            "uidname":"google.api_core.client_info",
+            "uid":"google.api_core.client_info"
+         },
+         {
+            "name":"ClientInfo",
+            "uidname":"google.api_core.client_info.ClientInfo",
+            "uid":"google.api_core.client_info.ClientInfo"
+         }
+      ]
+   },
+   {
+      "name":"client_info",
+      "uidname":"google.api_core.gapic_v1.client_info",
+      "items":[
+         {
+            "name":"Overview",
+            "uidname":"google.api_core.gapic_v1.client_info",
+            "uid":"google.api_core.gapic_v1.client_info"
+         },
+         {
+            "name":"ClientInfo",
+            "uidname":"google.api_core.gapic_v1.client_info.ClientInfo",
+            "uid":"google.api_core.gapic_v1.client_info.ClientInfo"
+         }
+      ]
+   },
+]