test: restore original udf in the remote function test, use supported type in the test data #996
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
shobsi
reviewed
Sep 19, 2024
shobsi
reviewed
Sep 19, 2024
| "index": [ | ||
| idx.item() if hasattr(idx, "item") else idx for idx in row.index | ||
| ], | ||
| "name": tuple( |
There was a problem hiding this comment.
doesn't the existing test highlight a gap between pandas and BigFrames. I'm concerned that by changing the test we can make it pass but leave the original issue unaddressed
There was a problem hiding this comment.
After discussing offline, we are now changing just the data in the tests. The remote function tests involved in this PR have custom udf that inspects the index data types. In pandas the index type can be numpy based (e.g. Int64) or non-numpy (e.g. int64). But in bigframes the types are always numpy based, so that is what we are going to use for these tests.
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: s
shobsi
changed the title
remote_function handler code
shobsi
changed the title
remote_function handler code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕