fix: remove the unused connection_client from the remote function #824
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: bigquery
jiaxunwu
changed the title
| @@ -654,9 +653,6 @@ def remote_function( | |||
| output_type: Optional[type] = None, | |||
| session: Optional[Session] = None, | |||
| bigquery_client: Optional[bigquery.Client] = None, | |||
| bigquery_connection_client: Optional[ | |||
There was a problem hiding this comment.
This is a breaking change. Please detect if this is set and warn with a FutureWarning that this argument is deprecated, instead.
There was a problem hiding this comment.
Thanks! Are we allowed to check in the breaking change? I do find it very confusing as a customer.
There was a problem hiding this comment.
I think the savior is that this is marked as deprecated for external use, so we can make a breaking change here?
| @@ -654,9 +653,6 @@ def remote_function( | |||
| output_type: Optional[type] = None, | |||
| session: Optional[Session] = None, | |||
| bigquery_client: Optional[bigquery.Client] = None, | |||
| bigquery_connection_client: Optional[ | |||
There was a problem hiding this comment.
I think the savior is that this is marked as deprecated for external use, so we can make a breaking change here?
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕