Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark filter() with model cascade on/off #1034

Merged
merged 1 commit into from
Oct 1, 2024
Merged

benchmark filter() with model cascade on/off #1034

merged 1 commit into from
Oct 1, 2024
+713 −138

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Oct 1, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sycai sycai requested review from a team as code owners October 1, 2024 06:14
@sycai sycai requested review from TrevorBergeron and removed request for a team October 1, 2024 06:14
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Oct 1, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 1, 2024
@sycai sycai merged commit 32d251e into main_chelsealin_lotus Oct 1, 2024
4 of 5 checks passed
@sycai sycai deleted the sycai_lotus branch October 1, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@jiaxunwu jiaxunwu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sycai @jiaxunwu