Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable model endpoint management for embeddings #233

Merged
merged 29 commits into from
Oct 23, 2024
Merged

feat: enable model endpoint management for embeddings #233

merged 29 commits into from
Oct 23, 2024

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Sep 16, 2024 •
edited
Loading

Implements Model Endpoint Management.

Covers:

  • Adding a new class AlloyDBEmbedding to use embedding functions in VectorStore's sql queries
  • Associated tests for AlloyDBEmbedding class.

go/mem-alloydb-langchain

@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Sep 16, 2024
@vishwarajanand vishwarajanand changed the title Mem proposal3 feat: enable model endpoint management for embeddings Sep 16, 2024
@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 16, 2024
averikitsch
averikitsch reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Let's review the user journeys before we approve

src/langchain_google_alloydb_pg/engine.py Outdated Show resolved Hide resolved
tests/test_async_vectorstore_search.py Show resolved Hide resolved
src/langchain_google_alloydb_pg/embeddings.py Outdated Show resolved Hide resolved
@vishwarajanand vishwarajanand removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 20, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review September 20, 2024 15:52
@vishwarajanand vishwarajanand requested review from a team as code owners September 20, 2024 15:52
@vishwarajanand vishwarajanand merged commit 247b9cf into main Oct 23, 2024
12 checks passed
@vishwarajanand vishwarajanand deleted the MEM-proposal3 branch October 23, 2024 09:30
@release-please release-please bot mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

@averikitsch averikitsch

Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishwarajanand @averikitsch @dishaprakash