-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: [gkeconnect] Update default transport type for Connect Gateway v1 client to "rest" #5798
Open
gcf-owl-bot
wants to merge
4
commits into
main
Choose a base branch
from
owl-bot-copy-packages-google-cloud-gkeconnect-gateway
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat!: [gkeconnect] Update default transport type for Connect Gateway v1 client to "rest" #5798
gcf-owl-bot
wants to merge
4
commits into
main
from
owl-bot-copy-packages-google-cloud-gkeconnect-gateway
+65
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to "rest" BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway. PiperOrigin-RevId: 695487411 Source-Link: googleapis/googleapis@5257378 Source-Link: googleapis/googleapis-gen@5dbaade Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiNWRiYWFkZTZkYzJmMTQ1YWExZWFmMzNkMGQ4YTA1MjE1NmE0OTA4OCJ9
/gcbrun |
gcf-owl-bot
bot
requested review from
yoshi-approver and
a team
as code owners
November 12, 2024 01:12
/gcbrun |
… "rest" BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway. PiperOrigin-RevId: 695803161 Source-Link: googleapis/googleapis@de97a5f Source-Link: googleapis/googleapis-gen@aebeaed Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiYWViZWFlZGVkZTU0NTQ1ZWUxNmU5YzEyYWY2NWNkYmE0MzcxMDMwZCJ9
gcf-owl-bot
bot
changed the title
feat!: [gkeconnect] Update default transport type for Connect Gateway v1beta1 client to "rest"
feat!: [gkeconnect] Update default transport type for Connect Gateway v1 client to "rest"
Nov 12, 2024
/gcbrun |
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
/gcbrun |
sofisl
approved these changes
Nov 14, 2024
sofisl
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Nov 14, 2024
Let's wait until Node 18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
owl-bot-copy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway.
PiperOrigin-RevId: 695803161
Source-Link: googleapis/googleapis@de97a5f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/aebeaedede54545ee16e9c12af65cdba4371030d
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiYWViZWFlZGVkZTU0NTQ1ZWUxNmU5YzEyYWY2NWNkYmE0MzcxMDMwZCJ9
BEGIN_NESTED_COMMIT
feat!: [gkeconnect] Update default transport type for Connect Gateway v1beta1 client to "rest"
BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway.
PiperOrigin-RevId: 695487411
Source-Link: googleapis/googleapis@5257378
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5dbaade6dc2f145aa1eaf33d0d8a052156a49088
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiNWRiYWFkZTZkYzJmMTQ1YWExZWFmMzNkMGQ4YTA1MjE1NmE0OTA4OCJ9
END_NESTED_COMMIT