Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Propagate repo level dependency change sdk-platform-java-config to each module's release notes #11294

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −11
Open

fix: Propagate repo level dependency change sdk-platform-java-config to each module's release notes #11294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9add7a3
fix: Propagate repo level dependency change to each module's release …
blakeli0 Nov 8, 2024
85e06ad
fix: Update golden tests.
blakeli0 Nov 8, 2024
6e52bfd
Merge branch 'main' into fix-release-notes
blakeli0 Nov 15, 2024
2ba2a48
Merge branch 'main' into fix-release-notes
blakeli0 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/release-note-generation/golden/java-analytics-admin/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@

### Dependencies

* **deps:** update dependency com.google.cloud:google-cloud-shared-config to v1.5.6 ([#9494](https://github.com/googleapis/google-cloud-java/issues/9494)) ([739763f](https://github.com/googleapis/google-cloud-java/commit/739763f15ffa2434d7fa089899165f1e8fa5f870))
* **deps:** update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#9505](https://github.com/googleapis/google-cloud-java/issues/9505)) ([30bc6f0](https://github.com/googleapis/google-cloud-java/commit/30bc6f0aef5b95549230dbd5b5246f2a8dab4ba4))
* **deps:** update dependency com.google.cloud:sdk-platform-java-config to v3.36.1 ([#11188](https://github.com/googleapis/google-cloud-java/pull/11188)) ([0200922](https://github.com/googleapis/google-cloud-java/commit/02009221d7d1966b4d180468f0cd1e32fbbab2c8))


## [0.15.0](https://github.com/googleapis/google-cloud-java/compare/google-analytics-admin-v0.14.1-SNAPSHOT...google-analytics-admin-v0.15.0) (2022-10-24)
Expand Down
3 changes: 1 addition & 2 deletions .github/release-note-generation/golden/java-maps-mapsplatformdatasets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@

### Dependencies

* **deps:** update dependency com.google.cloud:google-cloud-shared-config to v1.5.6 ([#9494](https://github.com/googleapis/google-cloud-java/issues/9494)) ([739763f](https://github.com/googleapis/google-cloud-java/commit/739763f15ffa2434d7fa089899165f1e8fa5f870))
* **deps:** update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#9505](https://github.com/googleapis/google-cloud-java/issues/9505)) ([30bc6f0](https://github.com/googleapis/google-cloud-java/commit/30bc6f0aef5b95549230dbd5b5246f2a8dab4ba4))
* **deps:** update dependency com.google.cloud:sdk-platform-java-config to v3.36.1 ([#11188](https://github.com/googleapis/google-cloud-java/pull/11188)) ([0200922](https://github.com/googleapis/google-cloud-java/commit/02009221d7d1966b4d180468f0cd1e32fbbab2c8))
3 changes: 1 addition & 2 deletions .github/release-note-generation/golden/java-vertexai/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@

### Dependencies

* **deps:** update dependency com.google.cloud:google-cloud-shared-config to v1.5.6 ([#9494](https://github.com/googleapis/google-cloud-java/issues/9494)) ([739763f](https://github.com/googleapis/google-cloud-java/commit/739763f15ffa2434d7fa089899165f1e8fa5f870))
* **deps:** update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#9505](https://github.com/googleapis/google-cloud-java/issues/9505)) ([30bc6f0](https://github.com/googleapis/google-cloud-java/commit/30bc6f0aef5b95549230dbd5b5246f2a8dab4ba4))
* **deps:** update dependency com.google.cloud:sdk-platform-java-config to v3.36.1 ([#11188](https://github.com/googleapis/google-cloud-java/pull/11188)) ([0200922](https://github.com/googleapis/google-cloud-java/commit/02009221d7d1966b4d180468f0cd1e32fbbab2c8))


## [0.15.0](https://github.com/googleapis/google-cloud-java/compare/google-analytics-admin-v0.14.1-SNAPSHOT...google-analytics-admin-v0.15.0) (2022-10-24)
Expand Down
2 changes: 1 addition & 1 deletion .github/release-note-generation/split_release_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def group_changes_by_api(main_changes: [str]):
def find_repo_wide_dependency_changes(main_changes: [str]):
repo_wide_changes = []
for changelog in main_changes:
match = re.search(r'\* (.+com\.google\.cloud:google-cloud-shared.+)',
match = re.search(r'\* (.+com\.google\.cloud:sdk-platform-java-config.+)',
changelog)
if match:
note = match.group(1)
Expand Down
3 changes: 1 addition & 2 deletions .github/release-note-generation/testdata/main_release_note.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
### Bug Fixes

* **deps:** update dependency com.google.cloud:google-cloud-pubsub-bom to v1.123.13 ([#9478](https://github.com/googleapis/google-cloud-java/issues/9478)) ([47778ff](https://github.com/googleapis/google-cloud-java/commit/47778ff0b2eb98b6354f237ee84df0dafc567bec))
* **deps:** update dependency com.google.cloud:google-cloud-shared-config to v1.5.6 ([#9494](https://github.com/googleapis/google-cloud-java/issues/9494)) ([739763f](https://github.com/googleapis/google-cloud-java/commit/739763f15ffa2434d7fa089899165f1e8fa5f870))
* **deps:** update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#9505](https://github.com/googleapis/google-cloud-java/issues/9505)) ([30bc6f0](https://github.com/googleapis/google-cloud-java/commit/30bc6f0aef5b95549230dbd5b5246f2a8dab4ba4))
* **deps:** update dependency com.google.cloud:sdk-platform-java-config to v3.36.1 ([#11188](https://github.com/googleapis/google-cloud-java/pull/11188)) ([0200922](https://github.com/googleapis/google-cloud-java/commit/02009221d7d1966b4d180468f0cd1e32fbbab2c8))
* **deps:** update dependency com.google.cloud:google-cloud-storage to v2.22.3 ([#9477](https://github.com/googleapis/google-cloud-java/issues/9477)) ([ce1ce33](https://github.com/googleapis/google-cloud-java/commit/ce1ce333f6e3e11a9382c8f29196b53c7afa21c2))


Expand Down
4 changes: 2 additions & 2 deletions .github/release-note-generation/unit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def test_create_changelog_entry(self):
def test_create_changelog_entry_only_deps(self):
dep_changes = ChangesOnApi(
dependency_upgrades=[
'update google-cloud-shared-dependencies to 1.2.3']
'update dependency com.google.cloud:sdk-platform-java-config to 1.2.3']
)
entry = create_changelog_entry(
'2023-06-10',
Expand All @@ -51,7 +51,7 @@ def test_create_changelog_entry_only_deps(self):

### Dependencies

* update google-cloud-shared-dependencies to 1.2.3
* update dependency com.google.cloud:sdk-platform-java-config to 1.2.3
''')

def test_create_changelog_entry_empty(self):
Expand Down
Loading