Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): Remove broken aliases #1079

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 16, 2024

*pb.go files for analytics were migrated from go-genproto repo to google-cloud-go. Although the type definitions have moved, aliases have been left in the old genproto packages to ensure a smooth non-breaking transition.

But some type definitions have been removed in this commit: googleapis/google-cloud-go#8749

Removing the broken aliases in this PR

@bhshkh bhshkh requested a review from a team as a code owner January 16, 2024 19:18
@bhshkh bhshkh merged commit 9144d31 into googleapis:main Jan 16, 2024
6 checks passed
@bhshkh bhshkh deleted the fix/analytics-broken-aliases branch January 16, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants