Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): update apidiff.yaml for submodules #1027

Merged
merged 1 commit into from
Jun 28, 2023
Merged

chore(all): update apidiff.yaml for submodules #1027

merged 1 commit into from
Jun 28, 2023

Conversation

quartzmo
Copy link
Member

No description provided.

@quartzmo quartzmo requested a review from a team as a code owner June 28, 2023 19:19
codyoss
codyoss reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the way we calculate what changed need to be updated to? I am not sure what we do in google-cloud-go

@quartzmo
Copy link
Member Author

Does the way we calculate what changed need to be updated to? I am not sure what we do in google-cloud-go.

Maybe not at the smaller scale (in terms of # of submodules) of go-genproto?

@quartzmo quartzmo merged commit e449d1e into googleapis:main Jun 28, 2023
4 checks passed
@quartzmo quartzmo deleted the apidiff-submodules branch June 28, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quartzmo @codyoss