-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new Unity build pipeline #138
base: master
Are you sure you want to change the base?
Conversation
Added new build pipeline script to automate the adding of iOS frameworks to the xcode project The old shell script and python scripts are no longer required, Unity now comes with xcode tools on the UnityEditor.iOS.Xcode namespace
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
using UnityEngine; | ||
using UnityEditor; | ||
using UnityEditor.Callbacks; | ||
using UnityEditor.iOS.Xcode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The namespace UnityEditor.iOS.Xcode
is define in "unityEditor.iOS.Extensions.xcode.dll" which is only installed when you also have IOSSupport playbackEngine installed. So you will want to add #if UNITY_IOS
guards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies you're right. I will correct it asap.
I'm using Xcode 8.3.2 and latest iOS SDK. Using this script, libz.dylib and libsqlite3.tbd would link to the wrong directory
the correct path should be
And libz.dylib no longer exist, replaced by libz.tbd. |
Support the new Unity build pipeline using
PostProcessBuildAttribute
Removed old shell scripts and implemented new c# script to automate adding of frameworks to xcode project using the new xcode tools provided by unity as part of the
UnityEditor.iOS.Xcode
namespace.The old PostProcessBuildPlayer_GA & mod_pbxproj.py scripts are not longer necessary or supported.