Add FromBytes::read_from_io and IntoBytes::write_to_io
#2016
Conversation
src/lib.rs
Outdated
| @@ -4525,6 +4529,24 @@ pub unsafe trait FromBytes: FromZeros { | |||
| } | |||
| } | |||
|
|
|||
| /// TODO | |||
src/lib.rs
Outdated
| @@ -5188,6 +5210,16 @@ pub unsafe trait IntoBytes { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// TODO | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2016 +/- ##
==========================================
+ Coverage 87.59% 87.64% +0.05%
==========================================
Files 16 16
Lines 5988 6016 +28
==========================================
+ Hits 5245 5273 +28
Misses 743 743 ☔ View full report in Codecov by Sentry. |
jswrenn
force-pushed
the
io
branch
2 times, most recently
from
e4949fb
to
6367580
Compare
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ```no_run |
There was a problem hiding this comment.
If you want this to run, you could use a trick like we do here:
Line 711 in ace5bb0
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ```no_run |
There was a problem hiding this comment.
If you want this to run, you could use a trick like we do here:
Line 711 in ace5bb0
There was a problem hiding this comment.
I don't think there's much sense in actually testing the IO. It'll make our tests more expensive to run, and will cause them to fail on platforms where file IO is stubbed out (e.g., wasm).
| /// This is a shorthand for `dst.write_all(self.as_bytes())`, and is useful | ||
| /// for interfacing with operating system byte sinks (files, sockets, etc.). |
There was a problem hiding this comment.
Same here - IMO we should remove the mention of OS byte sinks.
Makes progress on #158. Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Makes progress on #158.