Skip to content

Commit

Permalink
Update comments about why ActualValueInference might not load.
Browse files Browse the repository at this point in the history
`ActualValueInference`+ASM has been the default for Android builds inside Google (cl/492596588) and for external builds (cl/336875929) for a while now. It's still possible for users to manually exclude ASM or to run an optimizer that removes `ActualValueInference` (and ASM along with it). This CL attempts to make that clearer.

RELNOTES=n/a
PiperOrigin-RevId: 693057392
  • Loading branch information
cpovirk authored and Google Java Core Libraries committed Nov 4, 2024
1 parent b76833f commit 2ee4fac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/src/main/java/com/google/common/truth/Platform.java
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ static void cleanStackTrace(Throwable throwable) {
| LinkageError
| RuntimeException e) {
// Some possible reasons:
// - Inside Google, we omit ActualValueInference entirely under Android.
// - Outside Google, someone is running without ASM on the classpath.
// - Someone has omitted ASM from the classpath.
// - An optimizer has stripped ActualValueInference (though it's unusual to optimize tests).
// - There's a bug.
// - We don't handle a new bytecode feature.
// TODO(cpovirk): Log a warning, at least for non-ClassNotFoundException, non-LinkageError?
Expand Down

0 comments on commit 2ee4fac

Please sign in to comment.