Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to mv3 #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

port to mv3 #229

wants to merge 1 commit into from

Conversation

liao02x
Copy link

@liao02x liao02x commented May 6, 2022

Purpose of this PR: move away from manifest v2(which is out of support soon) to manifest v3

Main changes:

  • Replace window apis with chrome apis because window is not accessible from mv3 service worker
    • Replace window.open with chrome.windows.create
    • Port communication system from window messages to long time connections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant