executor: use any executor if the avoid mask included all of them #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avagin
force-pushed
the
syz-exec-avoid
branch
from
85dcccb
to
b25dbcc
Compare
|
This pr fixes the root cause of https://syzkaller.appspot.com/bug?extid=e3d9c150bd6e97f2fb71. |
avagin
force-pushed
the
syz-exec-avoid
branch
from
b25dbcc
to
b8c52b8
Compare
After 9fc8fe0 ("executor: better handling for hanged test processes"), yz-executor's responses may reference procids outside of the [0;procs] range. If procids are no longer dense on the syz-executor side, we cannot rely on this check in pkg/rpcserver: ``` if avoid == (uint64(1)<<runner.procs)-1 { avoid = 0 } ``` Signed-off-by: Andrei Vagin <[email protected]>
avagin
force-pushed
the
syz-exec-avoid
branch
from
b8c52b8
to
8dc9771
Compare
dvyukov
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 9fc8fe0 ("executor: better handling for hanged test processes"), syz-executor's responses may reference procids outside of the [0;procs] range.
If procids are no longer dense on the syz-executor side, we cannot rely on this check in pkg/rpcserver: