syz-manager: add common HTML header to every page #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dvyukov
commented
Nov 8, 2024
dvyukov
commented
- pkg/manager: add common page header type
- pkg/manager: add common HTML page header
- syz-manager: add pause function
- pkg/manager: wrap stats page with the common header
Add common page header to every page. This is similar to how we do in the dashboard app, and it will allow to have a common HTML page header.
dvyukov
changed the title
tarasmadan
reviewed
Nov 8, 2024
tarasmadan
reviewed
Nov 8, 2024
tarasmadan
reviewed
Nov 8, 2024
tarasmadan
reviewed
Nov 8, 2024
tarasmadan
reviewed
Nov 8, 2024
Add common HTML page header to every page. The header contains common tabs, and expert mode switch.
The pause function is useful to make manager stop consuming CPU for some time, e.g. when it runs on a shared machine, and a user wants to use CPU for something else. Previously one would need to kill the manager process and restart later to achieve this, but the restart is costly, and aborts all bug reproductions.
Add common manager HTML header to the stats page as well.
dvyukov
force-pushed
the
dvyukov-manager-iface
branch
from
ffdc385
to
25f4f57
Compare
dvyukov
force-pushed
the
dvyukov-manager-iface
branch
from
25f4f57
to
8475fe1
Compare
|
Need restamp after linter fix. |
tarasmadan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.