Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mobile tabbed view for Report Table and Popular Pages Widget. #9765

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Implement mobile tabbed view for Report Table and Popular Pages Widget. #9765

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d182f16
Add tab bar to ReportTable.
techanvil Nov 21, 2024
cfc1823
Extract and share tab bar styling from AudienceTiles component.
techanvil Nov 21, 2024
d3a9e91
Override `hideOnMobile` to `true` when `tabbedLayout` is `true`.
techanvil Nov 21, 2024
04ab480
Only show the selected tab when tabbed view is active.
techanvil Nov 25, 2024
90a454e
Specify data column width as a responsive percentage.
techanvil Nov 25, 2024
2c0cb03
Apply the tabbed layout at mobile breakpoints.
techanvil Nov 26, 2024
11cdcf3
Make popular page titles bold.
techanvil Nov 26, 2024
fc91fcf
Ensure the metric shown in the right hand column is not wrapped.
techanvil Nov 26, 2024
aee7d4d
Add a ReportTable story and scenario for the tabbed layout view.
techanvil Nov 26, 2024
a533015
Add/update reference images.
techanvil Nov 26, 2024
7c03cd5
Update snapshot.
techanvil Nov 26, 2024
c8b866e
Merge branch 'develop' into bug/7563-most-popular-pages-tabbed-view.
techanvil Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/js/components/DetailsPermaLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default function DetailsPermaLinks( { title, path, serviceURL } ) {
return (
<Fragment>
<Link
className="googlesitekit-font-weight-medium"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and set the medium font weight here so it's applied to the desktop viewport and WP dashboard "top content" widget as well, as per this Slack thread, as I think it's most likely that we'll go ahead with this approach.

If it turns out we decide not to, it will be quick to amend in a followup issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: This approach has now been agreed.

href={ serviceURL || detailsURL }
external={ !! serviceURL }
hideExternalIndicator
Expand Down
Loading
Loading