-
Notifications
You must be signed in to change notification settings - Fork 356
Fix using file instead of io.IOBase #140
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
This is not backwards-compatible with Python 2. Please check against |
Which method do you think is better in this case, using the tuple and try/except or checking |
I think |
Ok, the PR should be good now |
As mentioned in #126