Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance cleanup for test projects #453

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Maintenance cleanup for test projects #453

wants to merge 4 commits into from

Conversation

voidzcy
Copy link
Collaborator

@voidzcy voidzcy commented Dec 14, 2020 •
edited
Loading

Some cleanup for test projects. Commits can be reviewed separately.

  • testProjectDependentApp is identical to testProjectDependent except the former depends on testProjectJavaLibrary while the latter depends on testProject. They were the consumer projects that depends on projects built with java-library and java respectively. We can simply use the testProjectDependentApp consumer project by renaming testProjectJavaLibrary directory to testProject when composing the test project.
  • See commit messages for other cleanups.

@voidzcy voidzcy force-pushed the bugfix/clean_up_tests branch from 331cf6a to 80a0864 Compare December 14, 2020 08:24
@rougsig
Copy link
Collaborator

rougsig commented Jun 11, 2022

I want that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voidzcy @rougsig @ejona86