pw_build: Remove output_name attr in rust_library

It is possible that multiple versions of a same crate may exist in the dependency tree of a target. Setting output name to crate_name leads to muliple definitions of a target in Ninja. This change removes explicit output name. Different versions of the same crate can use rustflags = [ "-Cextra-filename=-<id>" ] to resolve conflict output names. Change-Id: I0a8e806affd01e32bcba6c0d99a23adccef58cd3 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/230012 Lint: Lint 🤖 <[email protected]> Reviewed-by: Jiacheng Lu <[email protected]> Reviewed-by: Erik Gilling <[email protected]> Commit-Queue: Jiacheng Lu <[email protected]>
google · Aug 21, 2024 · d0655bf · d0655bf
1 parent e224ccc
commit d0655bf
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/pw_build/rust_library.gni b/pw_build/rust_library.gni
@@ -61,7 +61,6 @@ template("pw_rust_library") {
     }
 
     crate_name = string_replace(crate_name, "-", "_")
-    output_name = crate_name
     output_dir = "${target_out_dir}/lib"
     add_global_link_deps = true
   }

diff --git a/pw_build/rust_staticlib.gni b/pw_build/rust_staticlib.gni
@@ -61,7 +61,6 @@ template("pw_rust_static_library") {
     }
 
     crate_name = string_replace(crate_name, "-", "_")
-    output_name = crate_name
     output_dir = "${target_out_dir}/lib"
     add_global_link_deps = true
     libs = [ "${output_name}" ]