*: Handle ignored status comments

- Ignore status in base64_over_hdlc.cc since logging from the logging code creates problems. - Ignore string::Copy() status in FreeRTOS stack overflow hook since the buffer is always appropriately sized. Fixes: b/357136096, b/357139112 Change-Id: I87e073471dff2d91d675864e01b3341ae5d3ba6f Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/229652 Presubmit-Verified: CQ Bot Account <[email protected]> Lint: Lint 🤖 <[email protected]> Reviewed-by: Anthony DiGirolamo <[email protected]> Commit-Queue: Auto-Submit <[email protected]> Pigweed-Auto-Submit: Wyatt Hepler <[email protected]>
google · Aug 14, 2024 · cc28da1 · cc28da1
1 parent 5b3ea9c
commit cc28da1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pw_log_tokenized/base64_over_hdlc.cc b/pw_log_tokenized/base64_over_hdlc.cc
@@ -41,8 +41,8 @@ extern "C" void pw_log_tokenized_HandleLog(
   const pw::InlineBasicString base64_string =
       PrefixedBase64Encode(log_buffer, size_bytes);
 
-  // HDLC-encode the Base64 string via a SysIoWriter.
-  // TODO: https://pwbug.dev/357136096 - Maybe don't ignore the error?
+  // HDLC-encode the Base64 string via a SysIoWriter. Ignore errors since we
+  // cannot take any action anyway.
   hdlc::WriteUIFrame(
       kBase64LogHdlcAddress, as_bytes(span(base64_string)), writer)
       .IgnoreError();

diff --git a/third_party/freertos/pw_assert_stack_overflow_hook.cc b/third_party/freertos/pw_assert_stack_overflow_hook.cc
@@ -28,7 +28,6 @@
 extern "C" void vApplicationStackOverflowHook(TaskHandle_t, char* pcTaskName) {
   // Copy the task name to a buffer in case it is corrupted.
   static char temp_thread_name_buffer[configMAX_TASK_NAME_LEN];
-  // TODO: https://pwbug.dev/357139112 - Review the IgnoreError call.
   pw::string::Copy(pcTaskName, temp_thread_name_buffer).IgnoreError();
   PW_CRASH("Stack overflow for task %s", temp_thread_name_buffer);
 }