bazel: Clean up empty globs

Cleans up uses of `glob()` that were sometimes empty to make Pigweed behave better with --incompatible_disallow_empty_glob. Bug: b/372510795 Change-Id: Ia7c4ec016243facf188099afbd6d9ab2266231bc Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256833 Docs-Not-Needed: Armando Montanez <[email protected]> Pigweed-Auto-Submit: Armando Montanez <[email protected]> Presubmit-Verified: CQ Bot Account <[email protected]> Reviewed-by: Ted Pudlik <[email protected]> Lint: Lint 🤖 <[email protected]> Commit-Queue: Auto-Submit <[email protected]>
google · Dec 30, 2024 · bc6e04c · bc6e04c
1 parent 256d1ec
commit bc6e04c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/pw_protobuf/BUILD.bazel b/pw_protobuf/BUILD.bazel
@@ -394,14 +394,6 @@ filegroup(
     ],
 )
 
-# TODO(frolv): Figure out what to do about size reports in Bazel.
-filegroup(
-    name = "size_reports",
-    srcs = glob([
-        "size_report/*.cc",
-    ]),
-)
-
 filegroup(
     name = "doxygen",
     srcs = [

diff --git a/pw_toolchain/rust/rust_toolchain.BUILD b/pw_toolchain/rust/rust_toolchain.BUILD
@@ -22,7 +22,11 @@ filegroup(
 
 filegroup(
     name = "rustc_lib",
-    srcs = glob(["lib/*.so"]),
+    srcs = glob(
+        ["lib/*.so"],
+        # For non-linux operating systems, this comes up empty.
+        allow_empty = True,
+    ),
     visibility = ["//visibility:public"],
 )
 

diff --git a/third_party/stm32cube/cmsis_core.BUILD.bazel b/third_party/stm32cube/cmsis_core.BUILD.bazel
@@ -22,6 +22,9 @@ cc_library(
             "Include/*.h",
             "Include/DSP/Include/*.h",
         ],
+        # Some include patterns come up blank, but exist for forward/backwards
+        # compatibility.
+        allow_empty = True,
     ),
     includes = [
         "Include",