pw_kvs: Move inline variable definition to .cc file

no_inline_ is defined as an inline variable. pw::Vector has a
non-default constructor, which causes Clang to use the SHF_GNU_RETAIN
section flag (at least when compiling for RP2). Since SHF_GNU_RETAIN is
a GNU extension, Clang sets the ELF's EI_OSABI field to ELFOSABI_GNU,
instead of the default ELFOSABI_NONE.

Picotool only accepts ELFs with an EI_OSABI of ELFOSABI_NONE, even if
the binary is actually compatible. To avoid this issue, do not use an
inline variable.

Bug: b/357162923
Change-Id: I396a59dad714c89957235c8e77c7ee2019ea37f5
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/228514
Pigweed-Auto-Submit: Wyatt Hepler <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Reviewed-by: Armando Montanez <[email protected]>
Lint: Lint 🤖 <[email protected]>
Presubmit-Verified: CQ Bot Account <[email protected]>

pw_blob_store/BUILD.bazel

@@ -62,11 +62,6 @@ pw_cc_test(
     srcs = [
         "blob_store_test.cc",
     ],
-    # TODO: b/357162923 - Fails on clang + Pico.
-    target_compatible_with = select({
-        "//targets/rp2040:pico_clang_build": ["@platforms//:incompatible"],
-        "//conditions:default": [],
-    }),
     deps = [
         ":pw_blob_store",
         "//pw_kvs:crc16",
@@ -84,11 +79,6 @@ pw_cc_test(
     srcs = [
         "blob_store_chunk_write_test.cc",
     ],
-    # TODO: b/357162923 - Fails on clang + Pico.
-    target_compatible_with = select({
-        "//targets/rp2040:pico_clang_build": ["@platforms//:incompatible"],
-        "//conditions:default": [],
-    }),
     deps = [
         ":pw_blob_store",
         "//pw_kvs:crc16",
@@ -105,11 +95,6 @@ pw_cc_test(
     srcs = [
         "blob_store_deferred_write_test.cc",
     ],
-    # TODO: b/357162923 - Fails on clang + Pico.
-    target_compatible_with = select({
-        "//targets/rp2040:pico_clang_build": ["@platforms//:incompatible"],
-        "//conditions:default": [],
-    }),
     deps = [
         ":pw_blob_store",
         "//pw_kvs:crc16",
@@ -124,11 +109,6 @@ pw_cc_test(
 pw_cc_test(
     name = "flat_file_system_entry_test",
     srcs = ["flat_file_system_entry_test.cc"],
-    # TODO: b/357162923 - Fails on clang + Pico.
-    target_compatible_with = select({
-        "//targets/rp2040:pico_clang_build": ["@platforms//:incompatible"],
-        "//conditions:default": [],
-    }),
     deps = [
         ":flat_file_system_entry",
         ":pw_blob_store",

pw_kvs/fake_flash_memory.cc

@@ -57,6 +57,8 @@ Status FlashError::Check(FlashMemory::Address start_address, size_t size) {
   return status_;
 }
 
+Vector<FlashError, 0> FakeFlashMemory::no_errors_;
+
 Status FakeFlashMemory::Erase(Address address, size_t num_sectors) {
   if (address % sector_size_bytes() != 0) {
     PW_LOG_ERROR(

pw_kvs/public/pw_kvs/fake_flash_memory.h

@@ -137,7 +137,7 @@ class FakeFlashMemory : public FlashMemory {
   }
 
  private:
-  static inline Vector<FlashError, 0> no_errors_;
+  static Vector<FlashError, 0> no_errors_;
 
   const span<std::byte> buffer_;
   Vector<FlashError>& read_errors_;