Skip to content

Commit

Permalink
pw_string: Disable wchar test for libcpp
Browse files Browse the repository at this point in the history
LLVM libcpp currently does not have wide character support.
Disabling related tests to support Clang toolchain Bazel build.

Bug: b/353604434
Change-Id: Ied8bfb0216bb5bfa2b726f50bc3710a716e4fefe
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/223581
Reviewed-by: Armando Montanez <[email protected]>
Lint: Lint 🤖 <[email protected]>
Pigweed-Auto-Submit: Prabhu Karthikeyan Rajasekaran <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Commit-Queue: Prabhu Karthikeyan Rajasekaran <[email protected]>
  • Loading branch information
Prabhuk authored and CQ Bot Account committed Jul 17, 2024
1 parent 4efaa47 commit 288cab8
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion pw_string/string_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2032,12 +2032,18 @@ TEST(InlineString, ComparisonOperators_NullTerminatedString) {
#else
#define PW_STRING_WRAP_TEST_EXPANSION(expr)
#endif // __cpp_constexpr >= 201603L

#ifdef _LIBCPP_HAS_NO_WIDE_CHARACTERS
#define TEST_FOR_TYPES_BASE(test_macro, ...) \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(char, __VA_ARGS__)); \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(char16_t, __VA_ARGS__)); \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(char32_t, __VA_ARGS__));
#else
#define TEST_FOR_TYPES_BASE(test_macro, ...) \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(char, __VA_ARGS__)); \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(wchar_t, __VA_ARGS__)); \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(char16_t, __VA_ARGS__)); \
PW_STRING_WRAP_TEST_EXPANSION(test_macro(char32_t, __VA_ARGS__));
#endif // _LIBCPP_HAS_NO_WIDE_CHARACTERS

#ifdef __cpp_char8_t
#define TEST_FOR_TYPES(test_macro, ...) \
Expand Down

0 comments on commit 288cab8

Please sign in to comment.