Alternative implementation of a magic framework. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docstring_parser for extracting argument description.
* determine type using annotations instead of docstring.
* deprecation of --bindto argument; Picatrix magic expect `line`
argument to be in a following format:
`{bind_variable} -- {magic_arguments}`
e.g. `%example var -- 1 2 3 --a=1` will run an `example` magic with
positional paramters set to `1`, `2` and `3` and keyword argument `a`
set to `1`. Results will be saved to `var` variable.
obsidianforensics
previously approved these changes
Nov 8, 2021
obsidianforensics
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docstring_parser for extracting argument description.
determine type using annotations instead of docstring.
deprecation of --bindto argument; Picatrix magic expect
lineargument to be in a following format:
{bind_variable} -- {magic_arguments}e.g.
%example var -- 1 2 3 --a=1will run anexamplemagic withpositional paramters set to
1,2and3and keyword argumentaset to
1. Results will be saved tovarvariable.This PR addresses #22 and #20, but isn't yet merged into rest of the framework.
I am going to fit it to the rest of the codebase in follow-up PRs.