Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #116: Static brotli overrides dynamic gzip #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamburgess
Copy link

@adamburgess adamburgess commented Apr 11, 2021

See #116 (comment)

Also adds two tests:

  1. static .br files are served: this downloads a file that has a static .br and compares it to the static .br on disk.
    • This test passes without this patch, it is included to add a little testing to the static module.
  2. dynamic gzip is used when .br doesn't exist: this downloads a file that does not have a static .br file, and ensures it is gzip compressed.
    • Without this patch, the test should fail.

@minac
Copy link

minac commented Jun 2, 2021

Hey 👋! Any news on when this can be merged?

@zhuizhuhaomeng
Copy link

@eustas Any news on when this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants