Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip:feat: adds Globus GCS-sourced assets as a datasource #666

Closed

Conversation

jbottigliero
Copy link

This pull request adds integration with Globus. Specifically, adding the ability to source data via HTTPS on a Globus Connect Server instance, authenticated using Globus Auth.

  • The credential_provider was created based off of the #src/util/google_oauth2.ts implementation and other OAuth-like credential providers (e.g. middleauth and ngauth).

The Globus credential provider uses PKCE for the authorization flow, which I've added a few basic utilities around 1.

Footnotes

  1. These utilities could be replaced with an external library (e.g. pkce-challenge) if that is preferred.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@joshmoore
Copy link
Contributor

joshmoore commented Dec 2, 2024

@jbottigliero: this sounds really interesting. Do you see coming back to it, or too much hassle?

(Edit: or did you just want another PR number? 😉)

@jbottigliero
Copy link
Author

Hey @joshmoore, the initial PR was a bit premature, but in a much better spot now.

It looks like I am unable to re-open this branch, so I've created a new one with the latest code: #675

(...which gives us a new number too! 😂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants