Support specifying worker thread affinities #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
force-pushed
the
thread-affinity-policy
branch
3 times, most recently
from
1159c99 to
a7148df
Compare
Add const flavors of `front()`, `back()`, `begin()`, `end()`.
ben-clayton
force-pushed
the
thread-affinity-policy
branch
from
a7148df to
7b2e43f
Compare
ben-clayton
force-pushed
the
thread-affinity-policy
branch
from
7b2e43f to
e0ea5ee
Compare
Add `Thread::Affinity` which describes the cores on which a thread can execute. Add `Thread::Affinity::Policy` which generates an `Affinity` for a thread by identifier. `Policy` contains two helper functions that return `Policy` implementations: * `anyOf()` returns a `Policy` that returns an Affinity for the available cores in the `Affinity` passed to the function. * `oneOf()` returns a `Policy` that returns an affinity with a single enabled core from the `Affinity` passed to the function. Other `Policy`s can be implemented by the user. Add a new `affinityPolicy` field to `Scheduler::Config` allowing the user to specify the rules for assigning thread affinities to each scheduler worker thread. Affinities are currently only supported on windows, linux and freebsd. Issue: google#136
ben-clayton
force-pushed
the
thread-affinity-policy
branch
from
e0ea5ee to
77e34d1
Compare
|
#147 contains these changes and was approved my @AWoloszyn. Landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Thread::Affinitywhich describes the cores on which a thread canexecute.
Add
Thread::Affinity::Policywhich generates anAffinityfor athread by identifier.
Policycontains two helper functions that returnPolicyimplementations:anyOf()returns aPolicythat returns an Affinity for theavailable cores in the
Affinitypassed to the function.oneOf()returns aPolicythat returns an affinity with a singleenabled core from the
Affinitypassed to the function.Other
Policys can be implemented by the user.Add a new
affinityPolicyfield toScheduler::Configallowing theuser to specify the rules for assigning thread affinities to each
scheduler worker thread.
Affinities are currently only supported on windows, linux and freebsd.
Issue: #136