Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compile error in concat_test.cc #2365

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fixed compile error in concat_test.cc #2365

merged 2 commits into from
Oct 30, 2024

Conversation

johnplatts
Copy link
Contributor

Updated TestConcatOddEven in concat_test.cc to fix compiler warning with hwy::Unpredictable1 (which returns a signed integer).

jan-wassenberg
jan-wassenberg reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Iota takes care of casting its second argument. Would you like to remove the ConvertScalarTo to shorten the code a bit?

jan-wassenberg
jan-wassenberg approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating 👍

@copybara-service copybara-service bot merged commit 1eb6fa5 into google:master Oct 30, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-wassenberg jan-wassenberg jan-wassenberg approved these changes

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnplatts @jan-wassenberg