Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for CIRCT's comb dialect #164

Merged
merged 1 commit into from
Sep 28, 2023
Merged

feat: add support for CIRCT's comb dialect #164

merged 1 commit into from
Sep 28, 2023

Conversation

asraa
Copy link
Collaborator

@asraa asraa commented Sep 14, 2023 •
edited
Loading

  • Adds a fork of CIRCT's Comb dialect (which also requires HW and some Support modules).

Fixes #110

@asraa asraa marked this pull request as draft September 14, 2023 23:17
@j2kun
Copy link
Collaborator

j2kun commented Sep 15, 2023

Still in a draft state, but you assigned me so I assume you want at least a pre-review. It LGTM! This seems like tedious work and so thank you for doing it.

@j2kun j2kun self-requested a review September 15, 2023 17:34
@asraa asraa marked this pull request as ready for review September 15, 2023 17:34
@asraa
Copy link
Collaborator Author

asraa commented Sep 15, 2023

Ready now! Note that the last change was that I excluded third_party from pre-commit formatting. I'm staging a PR that auto-updates the third_party folder weekly :)

@asraa asraa force-pushed the comb-dialect branch 2 times, most recently from 8e35655 to 5476b93 Compare September 15, 2023 17:54
@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Sep 15, 2023
@asraa asraa mentioned this pull request Sep 15, 2023
Closed
@asraa asraa force-pushed the comb-dialect branch 4 times, most recently from 605de55 to e1ee31d Compare September 18, 2023 18:26
@asraa asraa force-pushed the comb-dialect branch 13 times, most recently from 2348d0a to eab2b70 Compare September 27, 2023 19:36
@asraa asraa force-pushed the comb-dialect branch 2 times, most recently from b2d88b8 to 9ca3c6c Compare September 27, 2023 20:03
@asraa
Copy link
Collaborator Author

asraa commented Sep 27, 2023

@j2kun this is ready for re-review! Slimmed down - plus added a few regex's to ensure that we're adding // from @llvm-project on MLIR/LLVM includes.

j2kun
j2kun approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits, otherwise LGTM! I will do a second round of cleanup after this goes in.

include/Dialect/Comb/BUILD Outdated Show resolved Hide resolved
include/Dialect/Comb/BUILD Outdated Show resolved Hide resolved
@asraa
feat: copy circt files
8b443c0 
Signed-off-by: Asra Ali <[email protected]>
@asraa
Copy link
Collaborator Author

asraa commented Sep 27, 2023

all set! feel free to let me know what else to clean-up

@copybara-service copybara-service bot merged commit 93d62ea into google:main Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j2kun j2kun j2kun approved these changes

Assignees

@j2kun j2kun

Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: dialect to represent combinational circuits
2 participants
@asraa @j2kun