Work around docker v25 tarballs #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd only seen compressed layers have LayerSources. As of v25, docker puts all layers in here, uncompressed, which exposed a bug in how Descriptor interacts with partial's uncompressed layer handling. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
force-pushed
the
docker-25
branch
from
29e5660
to
fe745f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1872 +/- ##
==========================================
+ Coverage 71.65% 71.67% +0.01%
==========================================
Files 123 123
Lines 9928 9935 +7
==========================================
+ Hits 7114 7121 +7
Misses 2115 2115
Partials 699 699 ☔ View full report in Codecov by Sentry. |
imjasonh
approved these changes
Jan 29, 2024
pedjak
added a commit
to pedjak/up
that referenced
this pull request
Mar 26, 2024
Upgraded go-containerregistry library to v0.19.1 containing the right fix google/go-containerregistry#1872
pedjak
added a commit
to pedjak/up
that referenced
this pull request
Mar 26, 2024
Upgraded go-containerregistry library to v0.19.1 containing the right fix google/go-containerregistry#1872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd only seen compressed layers have LayerSources. As of v25, docker puts all layers in here, uncompressed, which exposed a bug in how Descriptor interacts with partial's uncompressed layer handling.
Fixes #1870