Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around docker v25 tarballs #1872

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Previously, we'd only seen compressed layers have LayerSources. As of v25, docker puts all layers in here, uncompressed, which exposed a bug in how Descriptor interacts with partial's uncompressed layer handling.

Fixes #1870

Previously, we'd only seen compressed layers have LayerSources. As of
v25, docker puts all layers in here, uncompressed, which exposed a bug
in how Descriptor interacts with partial's uncompressed layer handling.

Signed-off-by: Jon Johnson <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0658aa) 71.65% compared to head (fe745f7) 71.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   71.65%   71.67%   +0.01%     
==========================================
  Files         123      123              
  Lines        9928     9935       +7     
==========================================
+ Hits         7114     7121       +7     
  Misses       2115     2115              
  Partials      699      699              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imjasonh imjasonh merged commit 8dadbe7 into google:main Jan 29, 2024
18 checks passed
pedjak added a commit to pedjak/up that referenced this pull request Mar 26, 2024
Upgraded go-containerregistry library to v0.19.1 containing the right fix

google/go-containerregistry#1872
pedjak added a commit to pedjak/up that referenced this pull request Mar 26, 2024
Upgraded go-containerregistry library to v0.19.1 containing the right fix

google/go-containerregistry#1872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ggcr: Docker 25.0 breaks image handling
3 participants