feat: mutate on oci-layout #1869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
- Coverage 71.65% 71.46% -0.19%
==========================================
Files 123 123
Lines 9928 9954 +26
==========================================
Hits 7114 7114
- Misses 2115 2137 +22
- Partials 699 703 +4 ☔ View full report in Codecov by Sentry. |
imjasonh
reviewed
Jan 24, 2024
| @@ -137,7 +142,8 @@ func New(use, short string, options []crane.Option) *cobra.Command { | |||
| root.PersistentFlags().BoolVar(&insecure, "insecure", false, "Allow image references to be fetched without TLS") | |||
| root.PersistentFlags().BoolVar(&ndlayers, "allow-nondistributable-artifacts", false, "Allow pushing non-distributable (foreign) layers") | |||
| root.PersistentFlags().Var(platform, "platform", "Specifies the platform in the form os/arch[/variant][:osversion] (e.g. linux/amd64).") | |||
|
|
|||
| root.PersistentFlags().StringVar(&local, "local", "", "Use a local oci-layout as remote registry") | |||
There was a problem hiding this comment.
This feels like a big change, since it affects all commands. Would it be worth having some e2e tests that set up a local layout and crane pull --local=<that>, crane mutate, etc.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1433 but NOT COMPLETE!
Make most of the crane cli able to mutate images on oci-layout.
The idea is to introduce a local version for some functions in
v1/remotethat does the identical operation on an oci-layoutcc @developer-guy as you were interested in this.