Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/s3blob: Allow using s3ForcePathStyle as a synonym of use_path_style, for backwards compatibility with V1 #3505

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Nov 7, 2024

Fixes #3472.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.25%. Comparing base (e9bda0a) to head (742f884).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
blob/s3blob/s3blob.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3505   +/-   ##
=======================================
  Coverage   73.24%   73.25%           
=======================================
  Files         113      113           
  Lines       15051    15052    +1     
=======================================
+ Hits        11024    11026    +2     
+ Misses       3262     3261    -1     
  Partials      765      765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit 5695484 into google:master Nov 7, 2024
6 checks passed
@vangent vangent deleted the pathstyle branch November 7, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob/s3blob: s3ForcePathStyle stopped working in v0.39.0
1 participant