Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstore/gcpfilestore: add support for non-default databases. #3345

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

coryschwartz
Copy link
Contributor

Fixes: #3339

This edits the regex to allow non-default database names when creating Firestore collections.

In line with prior art, this also creates a helper function to assist with creating a valid scheme.

Copy link

google-cla bot commented Nov 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6d5d289) 77.47% compared to head (ff1f875) 77.44%.
Report is 1 commits behind head on master.

Files Patch % Lines
docstore/gcpfirestore/fs.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage   77.47%   77.44%   -0.03%     
==========================================
  Files         104      104              
  Lines       13933    13935       +2     
==========================================
- Hits        10794    10792       -2     
- Misses       2378     2382       +4     
  Partials      761      761              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit fa413a3 into google:master Nov 22, 2023
6 checks passed
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docstore/gcpfirestore: ought to support non-default databases
2 participants