Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update deps, including a breaking S3 change #3342

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Nov 21, 2023

Fixes #3341.

@chris-rock
Copy link

I would very much appreciate if a patch release could be published.

@vangent
Copy link
Contributor Author

vangent commented Nov 22, 2023

I would very much appreciate if a patch release could be published.

Sorry, I am trying, but it appears that a bunch of other things break when I update to this AWS release, not just the compilation errors. For example, they appear to have changed some returned errors so the error codes aren't right. Depending on how deep this goes, it may take a while to figure out.

@vangent
Copy link
Contributor Author

vangent commented Nov 22, 2023

For example, I am running into aws/aws-sdk-go-v2#2370 and aws/aws-sdk-go-v2#2348.

@vangent vangent force-pushed the awsupd branch 2 times, most recently from 8d5e1c6 to 02848bf Compare November 22, 2023 21:01
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa413a3) 77.44% compared to head (a2222da) 77.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3342   +/-   ##
=======================================
  Coverage   77.44%   77.44%           
=======================================
  Files         104      104           
  Lines       13935    13935           
=======================================
  Hits        10792    10792           
  Misses       2382     2382           
  Partials      761      761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit 53ccd8d into google:master Nov 22, 2023
6 checks passed
@vangent vangent deleted the awsupd branch November 22, 2023 21:14
@chris-rock
Copy link

Thank you @vangent

@adelamarre-pelm
Copy link

When is the next release containing this patch?

@vangent
Copy link
Contributor Author

vangent commented Dec 7, 2023

I will try to get to it this week, but note that you can use any version you like directly, you don't need to wait for a release.

@vangent
Copy link
Contributor Author

vangent commented Dec 8, 2023

Done.

ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Blob Incompatibility with AWS S3 Issues?
3 participants