Error out if we try to annotate a zero address #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the exegesis annotator error out if we try to map the zero address as we are not able to do this with mmap. To solve this while still being able to annotate the blocks, we probably need some way to adjust the register/memory values.
ondrasej
requested changes
Mar 14, 2024
ondrasej
approved these changes
Mar 18, 2024
boomanaiden154
deleted the
users/boomanaiden154/error-zero-address-exegesis-annotator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the exegesis annotator error out if we try to map the zero address as we are not able to do this with mmap. To solve this while still being able to annotate the blocks, we probably need some way to adjust the register/memory values.