Add JSON output option to BHive converter #38
Conversation
This patch adds a JSON output option to the BHive converter. This makes it significantly easier to implement other scripts down the line that ingest this data. This also cuts down the number of inodes that a large data set will use by a significant amount, which can be a problem on some file systems.
|
|
||
| if (file_ec) { | ||
| std::cerr << "Failed to open output file: " << json_output_file_path.str() | ||
| std::cerr << "Failed to open output file: " << json_output_file_path.c_str() |
There was a problem hiding this comment.
This is a bit expensive - would just json_output_file_path.str() work?
(maybe SmallString<> should have a std::string_view conversion just like llvm::StringRef does, and then this would work out of the box).
There was a problem hiding this comment.
I don't think c_str() should be that much more expensive? It pretty much just returns a pointer to the internal buffer here, which is also what ends up happening when converting to a std::string. I've changed it to use static_cast<std::string_view> as .str() just returns a StringRef which doesn't have standard output operators implemented (as they use the LLVM ones). StringRef::str() returns a std::string and doesn't automatically use the std::string_view conversion.
Implementing a std::string_view conversion for llvm::SmallString would make quite a bit of sense and I'll work on getting something up for that.
Let me know if the approach here needs some adjustment and I can open up a new PR fixing it.
This patch adds a JSON output option to the BHive converter. This makes it significantly easier to implement other scripts down the line that ingest this data. This also cuts down the number of inodes that a large data set will use by a significant amount, which can be a problem on some file systems.